Open
Conversation
Arshdeep54
force-pushed
the
batch-insert
branch
2 times, most recently
from
d53524a to
c0ffbe6
Compare
4adex
reviewed
Mar 25, 2026
| #[derive(Serialize, Deserialize, Clone, Debug, PartialEq)] | ||
| pub struct Point { | ||
| pub id: PointId, | ||
| pub id: Option<PointId>, |
Collaborator
There was a problem hiding this comment.
Shouldn't id be necessary in a Point? what does a point with None id signify?
Contributor
Author
There was a problem hiding this comment.
While inserting (mostly in batch inserts), the user may not provide an id. In that case, the server generates an 'id` for that.
Signed-off-by: Arshdeep54 <balarsh535@gmail.com>
Arshdeep54
force-pushed
the
batch-insert
branch
from
c0ffbe6 to
8effb88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.