Open
Conversation
Signed-off-by: karma <captainav0608@gmail.com>
Signed-off-by: karma <captainav0608@gmail.com>
Signed-off-by: karma <captainav0608@gmail.com>
Signed-off-by: karma <captainav0608@gmail.com>
Signed-off-by: karma <captainav0608@gmail.com>
Signed-off-by: karma <captainav0608@gmail.com>
kunalvirwal
requested changes
Feb 9, 2026
Collaborator
There was a problem hiding this comment.
Combine Create, Update, Upsert
| SecretColUpdatedAt = "updated_at" | ||
| ) | ||
|
|
||
| type Secret struct { |
Collaborator
There was a problem hiding this comment.
Look at gorm implementations on how validation strings work.
|
|
||
| // NOTE : the values of constants must be consistent to the "column" in gorm tags. | ||
| const ( | ||
| // table name |
| WebhookColUpdatedAt = "updated_at" | ||
| ) | ||
|
|
||
| type Webhook struct { |
| } | ||
|
|
||
| func (s *secretStore) Create(ctx context.Context, secrets []models.Secret) error { | ||
| if ctx.Err() != nil { |
Collaborator
There was a problem hiding this comment.
Should/Can we use ctx.Done channel here.
Contributor
Author
There was a problem hiding this comment.
using the channel would result in writing a dedicated select block in each of the function, where the default case would be the execution part. also in the error we will have to pass ctx.Err anyways.
checking ctx.Err() directly is comparitively straighforward and readable.
|
|
||
| db-run: | ||
| @echo "Starting database container '$(DB_CONTAINER_NAME)' on port $(DB_PORT)..." | ||
| docker run --name $(DB_CONTAINER_NAME) \ |
Collaborator
There was a problem hiding this comment.
make a bind mount for the db data
makefile
Outdated
| @@ -0,0 +1,26 @@ | |||
| DB_CONTAINER_NAME=shogun_db | |||
| DB_PORT=5434 | |||
Collaborator
There was a problem hiding this comment.
Use default postgres port for now
Signed-off-by: karma <captainav0608@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3 and #4