SEAMWICKET-40 Make dependency on weld-servlet-core truly optional #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-40 Make dependency on weld-servlet-core truly optional)
…40 Make dependency on weld-servlet-core truly optional.
…ersion is in <depMgmt>.
…ersion is in <depMgmt>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, these are changes which will make using seam-wicket easier in embedded container in Java SE applications using weld-se-core (can't be used together with weld-servlet-core, both have own bootstrap).
Class changes allow people to use only @Inject in wicket components, without Conversation.
Conversation is @RequestScoped, which is handled by weld-servlet-core.
I suggest to modify weld-servlet-core so it doesn't bootstrap weld if it's already done by weld-se-core.
The POM change only explicitly states the dependency on weld-servlet-core.