url decode path segments with warp::path::param()#1026
Open
urkle wants to merge 1 commit intoseanmonstar:masterfrom
Open
url decode path segments with warp::path::param()#1026urkle wants to merge 1 commit intoseanmonstar:masterfrom
urkle wants to merge 1 commit intoseanmonstar:masterfrom
Conversation
urkle
force-pushed
the
feat-param-url-decoding
branch
2 times, most recently
from
53beb0b to
5e7db03
Compare
urkle
force-pushed
the
feat-param-url-decoding
branch
from
5e7db03 to
6d54ce9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #704 except it simply always decodes the path pieces before parsing.
This matches the behavior for query params where they are decoded by serde_urlencoded.
This PR also adds test for filters::path::param as well as for filters::query::query to assert the handling.