add custom path matcher#1030
Open
urkle wants to merge 1 commit intoseanmonstar:masterfrom
Open
Conversation
urkle
force-pushed
the
feat-custom-path-filter
branch
from
9401dfa to
390fe84
Compare
- this allows a custom function to - match multiple path segments - extract whatever it wants from the path - advance the consumed path to use path()/end() after
urkle
force-pushed
the
feat-custom-path-filter
branch
from
390fe84 to
b7a8f85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be able to fulfill #808, 542, as well as some needs I have to extract multiple inner path segments.
@seanmonstar One question I do have for you is should we build some builder methods around the return value in to the function to make it more friendly? As having to return a nested tuple like that is kinda icky. And if so, what structure would you suggest?