Provide warp::cloned to simplify passing shared services to routes#1109
Open
andyHa wants to merge 7 commits intoseanmonstar:masterfrom
Open
Provide warp::cloned to simplify passing shared services to routes#1109andyHa wants to merge 7 commits intoseanmonstar:masterfrom
andyHa wants to merge 7 commits intoseanmonstar:masterfrom
Conversation
with_cloneable is essentially a shortcut for: crate::any().map(move || value.clone())
Owner
|
Sorry, I hadn't been paying attention to the notifications here, I was way too busy with other things. I've finally gotten back to fixing up warp some. I appreciate the goal here, and I admit I'm slightly torn. On the one hand, since If I did merge something like this, I think I'd lean towards a different name. Possibly |
andyHa
changed the title
Before 0.4 a stream could by sent as body via Body::wrap_stream. This has been made private to not expose any internal workings. With this change, replying with a stream is possible again without exposing any internals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing shared services to routes is a very common task. Most of the time these implement
Cloneas they're most probably wrapped as
Arcanyway. Usingwith_cloneableis a bit shorter andmore concise than
crate::any().map(move || value.clone()).