Fixes Issue #1113: TLS: Ignore certs in pem file when loading private key#1114
Open
jdthomas wants to merge 3 commits intoseanmonstar:masterfrom
Open
Fixes Issue #1113: TLS: Ignore certs in pem file when loading private key#1114jdthomas wants to merge 3 commits intoseanmonstar:masterfrom
jdthomas wants to merge 3 commits intoseanmonstar:masterfrom
Conversation
19bf761 to
c794232
Compare
Author
|
Looks like rusttls-pemfile also has a https://docs.rs/rustls-pemfile/latest/rustls_pemfile/fn.private_key.html [edit: might look something like this: https://github.com/jdthomas/warp/commit/ff9c9a0892e29259dc7a16cc948a9576129e0039 ] |
c1832bb to
54d7133
Compare
Author
|
Any thoughts on merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ignores just certs in the file. Options I considered:
Ignore all the non-key items. replacing with
_ => {},Ignore explicitly the existing entries in
rustls_pemfile::Item::*that are not a key. replacing withrustls_pemfile::Item::X509Certificate(_) | Crl(_) | Csr(_) => {},Ignore just the certs
X509Certificate(_) => {}, _ => return Err(TlsConfigError::UnknownPrivateKeyFormat),Any of those would resolve my issue of certs + keys in same file, happy to adjust diff as needed.