Create Body from &'static [u8].#1144
Merged
seanmonstar merged 1 commit intoseanmonstar:masterfrom Oct 20, 2025
Merged
Conversation
Contributor
Author
|
I believe the CI failure is unrelated, and fixed in #1142 . Edit: Yes, I rebased and now the tests pass. |
In warp 0.3 there was a convenient converter from a static byte slice to response body. Since warp 0.4 has sucn converters for `String`, `&str`, and `Vec<u8>`, I think it would be reasonable to have such a converter for `&[u8]` as well.
kaj
force-pushed
the
body-from-static-u8s
branch
from
7b51315 to
0d288ad
Compare
seanmonstar
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In warp 0.3 there was a convenient converter from a static byte slice to a response body, so this fixes a minor regression.
Since warp 0.4 has such converters for
String,&str, andVec<u8>, I think it would be reasonable to have such a converter for&[u8]as well.Alternatives
It would be possible to add a generic
impl<T: Into<Bytes>> From<T> for Bodyinstead. But perhaps that would have confusing side effects?Of course, the using create could also make the conversion though
Bytes, but sincewarpdoes not re-export it the calling crate would then need a direct dependency onbytes.