Remove Sync requirement on Body and Stream objects#1154
Open
macladson wants to merge 1 commit intoseanmonstar:masterfrom
Open
Remove Sync requirement on Body and Stream objects#1154macladson wants to merge 1 commit intoseanmonstar:masterfrom
Sync requirement on Body and Stream objects#1154macladson wants to merge 1 commit intoseanmonstar:masterfrom
Conversation
seanmonstar
reviewed
Mar 17, 2026
|
|
||
| #[derive(Debug)] | ||
| pub struct Body(BoxBody<Bytes, crate::Error>); | ||
| pub struct Body(UnsyncBoxBody<Bytes, crate::Error>); |
Owner
There was a problem hiding this comment.
I think this would be a breaking change. Body no longer would satisfy Sync bounds. So, if somewhere else someone was putting warp::Body into a BoxBody, this change will cause compiler errors.
Author
There was a problem hiding this comment.
Ah yes, good point. This would have to go into a major release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1153
Remove
SyncfromBody's trait bounds.Also removes
Syncfrom the variousStreamobjects as this also appears safe.