fix: Don't treat OPTIONS as CORS preflight if request-method not set#1158
Merged
seanmonstar merged 1 commit intoseanmonstar:masterfrom Apr 15, 2026
Merged
fix: Don't treat OPTIONS as CORS preflight if request-method not set#1158seanmonstar merged 1 commit intoseanmonstar:masterfrom
seanmonstar merged 1 commit intoseanmonstar:masterfrom
Conversation
As per the spec (https://fetch.spec.whatwg.org/#http-requests) and the MDN docs (https://developer.mozilla.org/en-US/docs/Glossary/Preflight_request), a CORS preflight request should include at least the Origin as well as Access-Control-Request-Method headers in the OPTIONS request. So we should not consider an OPTIONS request as a CORS preflight request if it does not include the Access-Control-Request-Method header and instead return Validated:::NotCors, so it will pass through
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the spec (https://fetch.spec.whatwg.org/#http-requests) and the MDN docs (https://developer.mozilla.org/en-US/docs/Glossary/Preflight_request), a CORS preflight request should include at least the Origin as well as Access-Control-Request-Method headers in the OPTIONS request.
So we should not consider an OPTIONS request as a CORS preflight request if it does not include the Access-Control-Request-Method header and instead return Validated:::NotCors, so it will pass through