Prevent VM deployment on standby/maintenancne nodes#870
Merged
insatomcat merged 1 commit intoseapath:mainfrom Feb 20, 2026
Merged
Conversation
dupremathieu
approved these changes
Feb 19, 2026
Member
|
LGTM but @dahoat-sprecher you need "signed" your commit: https://github.com/seapath/ansible?tab=contributing-ov-file#license-and-developer-certificate-of-origin |
dahoat-sprecher
force-pushed
the
prevent-vm-deploy-on-standby-nodes
branch
from
db35f09 to
865efb2
Compare
Contributor
Author
|
Well that was embarrassing as I made sure to tick the checkbox but forgot to double check after I fixed a typo in the commit message 😅 Should be fixed now. |
When a node is on standby, attempts to use vm-mgr for deployment just produce timeouts. Before that, the VM disk was already copied onto the machine. This commit provides an early check to prevent VM deployments which are going to fail. Signed-off-by: Daniel Hofer <daniel.hofer@sprecher-automation.com>
insatomcat
force-pushed
the
prevent-vm-deploy-on-standby-nodes
branch
from
865efb2 to
97b2559
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello to All,
something I learned the hard way:
When a node is on standby, attempts to use vm-mgr for deployment just produce timeouts. This commit adds checks to fail deployments early to prevent waiting and also tell users, why the deployment failed.
Best regards,
Daniel