Merged
Conversation
Member
dupremathieu
commented
Feb 19, 2026
dupremathieu
commented
- add a GitHub action that check if the code is properly formatted and run the Python linter flake8
- fix flake8 issues
- add tests
Member
Author
insatomcat
previously approved these changes
Feb 19, 2026
Run black formatting check and flake8 linting via cqfd on pushes and pull requests to main. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mathieu Dupré <mathieu.dupre@savoirfairelinux.com>
Signed-off-by: Mathieu Dupré <mathieu.dupre@savoirfairelinux.com>
Add real (non-mocked) pytest tests for standalone mode running against qemu:///system. Tests cover LibVirtManager helpers and the public vm_manager_libvirt API (create, remove, start, stop, status, autostart). - Add tests/conftest.py with shared fixtures (vm_name, libvirt_conn) - Add tests/test_libvirt_manager.py (10 tests) - Add tests/test_vm_manager_libvirt.py (12 tests) - Add CI test job with libvirt + QEMU on Ubuntu 24.04 - Add pytest as optional test dependency - Use qemu64 CPU model in testdata XML for CI portability Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mathieu Dupré <mathieu.dupre@savoirfairelinux.com>
dupremathieu
dismissed
insatomcat’s stale review
The merge-base changed after approval.
|
Member
Author
|
The rebase has removed the approval @insatomcat |
insatomcat
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.