Skip to content

feat: @EntityGraph 추가, TPS ngrinder로 확인 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

feat: @EntityGraph 추가, TPS ngrinder로 확인 #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
67664ee
feat: @EntityGraph 추가, TPS ngrinder로 확인
KindNeighbor Apr 7, 2023
d7fe7e3
fix: TPS 전후 확인을 위해서 @EntityGraph 주석처리
KindNeighbor Apr 7, 2023
8e53b48
fix: native 쿼리로 변경해서 한번에 조인
KindNeighbor Apr 8, 2023
d218cf8
fix: @param 추가
KindNeighbor Apr 8, 2023
4706662
fix: 처음 상태로 되돌림. 쿼리 확인
KindNeighbor Apr 8, 2023
f83b8ea
fix: @EntityGraph member 테이블에 적용
KindNeighbor Apr 8, 2023
d1da4a2
fix : @EntityGraph 제거 #2
KindNeighbor Apr 8, 2023
df85447
feat: batch fetch size 추가, format_sql 추가
KindNeighbor Apr 9, 2023
500b345
fix: join추가로 쿼리 한줄 줄임
KindNeighbor Apr 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/example/seatchoice/repository/CommentRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@
import com.example.seatchoice.entity.Comment;
import com.example.seatchoice.entity.Review;
import java.util.List;
import org.springframework.data.jpa.repository.EntityGraph;
import org.springframework.data.jpa.repository.JpaRepository;
import org.springframework.stereotype.Repository;

@Repository
public interface CommentRepository extends JpaRepository<Comment, Long> {

// @EntityGraph(attributePaths = {"member"})
List<Comment> findAllByReview(Review review);

}
1 change: 1 addition & 0 deletions src/main/java/com/example/seatchoice/repository/reviewPaging/ReviewRepositoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ public Slice<ReviewInfoResponse> searchBySlice(Long lastReviewId, Long seatId,
Pageable pageable) {
List<Review> reviews = queryFactory
.selectFrom(review)
.join(review.theaterSeat).fetchJoin()
.where(
ltReviewId(lastReviewId), // review.id < lastReviewId
review.theaterSeat.id.eq(seatId)
Expand Down
4 changes: 4 additions & 0 deletions src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ spring:
hibernate:
ddl-auto: update
show-sql: true
properties:
hibernate:
format_sql: true
default_batch_fetch_size: 100

# 이미지 용량
servlet:
Expand Down