Exposed fields related to accessibility#415
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes additional accessibility-related fields across the codebase to provide more detailed seat characteristics for events and charts.
Changes:
- Added five new accessibility properties:
hasLiftUpArmrests,isHearingImpaired,isSemiAmbulatorySeat,hasSignLanguageInterpretation, andisPlusSize - Updated data models (
EventObjectInfoandChartObjectInfo) to include the new fields - Extended test coverage to validate the new properties
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Events/EventObjectInfo.ts | Added five new optional boolean fields and their assignments in the constructor |
| src/Charts/ChartObjectInfo.ts | Added five new optional boolean fields and their assignments in the constructor |
| tests/reports/events/eventReport.test.ts | Added assertions for the new accessibility fields in both regular and GA test cases |
| tests/reports/charts/chartReport.test.ts | Replaced generic toBeDefined() checks with specific toBe(false) assertions for existing fields and added tests for new accessibility fields |
| tests/events/changeObjectStatus.test.ts | Added the new accessibility fields to the test object with false values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.