Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes additional accessibility-related fields in event and chart object information classes. The changes add support for tracking various accessibility features of seats including lift-up armrests, hearing impairment accommodations, semi-ambulatory seating, sign language interpretation availability, and plus-size seating options.
Changes:
- Added five new boolean accessibility properties to both
EventObjectInfoandChartObjectInfoclasses - Updated test assertions to verify these new fields are properly initialized with false/null values depending on context
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Events/EventObjectInfo.php | Added five new accessibility-related boolean properties with PHPDoc annotations |
| src/Charts/ChartObjectInfo.php | Added the same five accessibility properties to maintain consistency with EventObjectInfo |
| tests/Reports/Events/EventReportsTest.php | Added test assertions for the new accessibility fields in both regular and GA (General Admission) test cases |
| tests/Reports/Charts/ChartReportsTest.php | Updated test to assert false values for new accessibility fields and changed existing accessibility assertions from assertNotNull to assertFalse |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.