Merged
Conversation
…n release script directly with npx
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the release workflow by eliminating the need for a node_modules directory and adds explicit package configuration to the Python build system.
- Replaced
yarndependency management withnpxfor temporary package installation in the release workflow - Added explicit package configuration to
pyproject.tomlfor setuptools
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/release.yml |
Replaced yarn-based dependency installation with npx for temporary package usage, removing the need for node_modules directory creation and cleanup |
pyproject.toml |
Added [tool.setuptools] section to explicitly specify the seatsio package for inclusion in the build |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 fixes:
npxfor running the release script withzxandsemveras temporary dependencies. That way there's no need for anode_modulesfolder, nor for installing dependencies.[tool.setuptools]section topyproject.tomlto explicitly specify theseatsiopackage for inclusion in the build.