Skip to content

Fix releasing #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroloux merged 1 commit into from
Dec 22, 2025
Merged

Fix releasing #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "seatsio"
version = "83.2.0"
version = "83.3.0"
description = "The official Seats.io Python SDK"
readme = "README.md"
requires-python = ">=3.9"
Expand All @@ -26,7 +26,4 @@ Issues = "https://github.com/seatsio/seatsio-python/issues"

[build-system]
requires = ["setuptools"]
build-backend = "setuptools.build_meta"

[tool.setuptools]
packages = ["seatsio"]
build-backend = "setuptools.build_meta"
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the [tool.setuptools] packages configuration is likely the root cause of the incomplete release. Without explicitly specifying packages = ["seatsio"], setuptools won't know which package to include in the distribution, resulting in an empty or incomplete package. This configuration should be kept to ensure the seatsio package is properly included in the release.

Suggested change
build-backend = "setuptools.build_meta"
build-backend = "setuptools.build_meta"
[tool.setuptools]
packages = ["seatsio"]

Copilot uses AI. Check for mistakes.
26 changes: 13 additions & 13 deletions release.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,21 +52,21 @@ async function determineNextVersionNumber(previous) {
return semver.inc(previous, versionToBump)
}

async function ensurePyProjectVersionMatchesTheLatestTag() {
const pyproject = await fs.readFile("pyproject.toml", "utf8")
const match = pyproject.match(/^\s*version\s*=\s*"([^"]+)"\s*$/m)
if (!match) throw new Error("Could not find version in pyproject.toml")
const currentVersion = match[1]
if (currentVersion !== latestVersion) {
throw new Error(`pyproject.toml version (${currentVersion}) does not match latest release tag (${latestVersion})`)
}
async function bumpVersionInFiles() {
await replaceInFile("pyproject.toml", `version = "${latestVersion}"`, `version = "${nextVersion}"`)
}

async function bumpVersionInFiles() {
await ensurePyProjectVersionMatchesTheLatestTag()
await $`uv version ${nextVersion}`
await gitAdd("pyproject.toml")
await gitAdd("uv.lock")
async function replaceInFile(filename, latestVersion, nextVersion) {
return await fs.readFile(filename, 'utf8')
.then(text => {
if (text.indexOf(latestVersion) < 0) {
throw new Error('Not the correct version. Could not find ' + latestVersion + ' in ' + filename)
}
return text
})
.then(text => text.replace(latestVersion, nextVersion))
Comment on lines +59 to +67
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The replaceInFile function has incorrect parameter naming. The parameters are named 'latestVersion' and 'nextVersion', but they're being used as generic 'old text' and 'new text' strings. The function performs a simple string replacement of the second parameter with the third parameter, so the parameter names should be more generic like 'oldText' and 'newText' or 'searchText' and 'replacementText' to avoid confusion.

Suggested change
async function replaceInFile(filename, latestVersion, nextVersion) {
return await fs.readFile(filename, 'utf8')
.then(text => {
if (text.indexOf(latestVersion) < 0) {
throw new Error('Not the correct version. Could not find ' + latestVersion + ' in ' + filename)
}
return text
})
.then(text => text.replace(latestVersion, nextVersion))
async function replaceInFile(filename, searchText, replacementText) {
return await fs.readFile(filename, 'utf8')
.then(text => {
if (text.indexOf(searchText) < 0) {
throw new Error('Not the correct version. Could not find ' + searchText + ' in ' + filename)
}
return text
})
.then(text => text.replace(searchText, replacementText))

Copilot uses AI. Check for mistakes.
Comment on lines +59 to +67
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message incorrectly refers to the parameter as 'latestVersion' when it's actually the second parameter passed to the function. The error message should be more accurate to reflect that it's checking for the presence of the search text. For clarity, consider updating the error message to match the actual purpose of the check.

Suggested change
async function replaceInFile(filename, latestVersion, nextVersion) {
return await fs.readFile(filename, 'utf8')
.then(text => {
if (text.indexOf(latestVersion) < 0) {
throw new Error('Not the correct version. Could not find ' + latestVersion + ' in ' + filename)
}
return text
})
.then(text => text.replace(latestVersion, nextVersion))
async function replaceInFile(filename, searchText, nextVersion) {
return await fs.readFile(filename, 'utf8')
.then(text => {
if (text.indexOf(searchText) < 0) {
throw new Error('Could not find search text "' + searchText + '" in ' + filename)
}
return text
})
.then(text => text.replace(searchText, nextVersion))

Copilot uses AI. Check for mistakes.
.then(text => fs.writeFileSync(filename, text))
.then(() => gitAdd(filename))
}

async function gitAdd(filename) {
Expand Down
2 changes: 1 addition & 1 deletion uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.