Skip to content

Exposed fields related to accessibility #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroloux merged 1 commit into from
Feb 6, 2026
Merged

Exposed fields related to accessibility #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions seatsio/domain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,11 @@ def __init__(self, item_data):
self.num_seats = item_data.get('numSeats')
self.is_accessible = item_data.get("isAccessible")
self.is_companion_seat = item_data.get("isCompanionSeat")
self.has_lift_up_armrests = item_data.get("hasLiftUpArmrests")
self.is_hearing_impaired = item_data.get("isHearingImpaired")
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field name 'is_hearing_impaired' uses potentially outdated terminology. Consider using more inclusive language such as 'is_deaf_or_hard_of_hearing' or 'requires_hearing_accessibility' to align with current accessibility best practices.

Suggested change
self.is_hearing_impaired = item_data.get("isHearingImpaired")
self.is_deaf_or_hard_of_hearing = item_data.get("isHearingImpaired")

Copilot uses AI. Check for mistakes.
self.is_semi_ambulatory_seat = item_data.get("isSemiAmbulatorySeat")
self.has_sign_language_interpretation = item_data.get("hasSignLanguageInterpretation")
self.is_plus_size = item_data.get("isPlusSize")
self.has_restricted_view = item_data.get("hasRestrictedView")
self.zone = item_data.get("zone")
self.floor = item_data.get("floor")
Expand Down Expand Up @@ -304,6 +309,11 @@ def __init__(self, item_data):
self.extra_data = item_data.get("extraData")
self.is_accessible = item_data.get("isAccessible")
self.is_companion_seat = item_data.get("isCompanionSeat")
self.has_lift_up_armrests = item_data.get("hasLiftUpArmrests")
self.is_hearing_impaired = item_data.get("isHearingImpaired")
self.is_semi_ambulatory_seat = item_data.get("isSemiAmbulatorySeat")
self.has_sign_language_interpretation = item_data.get("hasSignLanguageInterpretation")
self.is_plus_size = item_data.get("isPlusSize")
self.has_restricted_view = item_data.get("hasRestrictedView")
self.displayed_object_type = item_data.get("displayedObjectType")
self.parent_displayed_object_type = item_data.get("parentDisplayedObjectType")
Expand Down
11 changes: 8 additions & 3 deletions tests/reports/charts/testChartReports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,14 @@ def test_reportItemProperties(self, update_chart, get_report):
assert_that(report_item.left_neighbour).is_none()
assert_that(report_item.right_neighbour).is_equal_to("A-2")
assert_that(report_item.distance_to_focal_point).is_not_none()
assert_that(report_item.is_accessible).is_not_none()
assert_that(report_item.is_companion_seat).is_not_none()
assert_that(report_item.has_restricted_view).is_not_none()
assert_that(report_item.is_accessible).is_false()
assert_that(report_item.is_companion_seat).is_false()
assert_that(report_item.has_lift_up_armrests).is_false()
assert_that(report_item.is_hearing_impaired).is_false()
assert_that(report_item.is_semi_ambulatory_seat).is_false()
assert_that(report_item.has_sign_language_interpretation).is_false()
assert_that(report_item.is_plus_size).is_false()
assert_that(report_item.has_restricted_view).is_false()
assert_that(report_item.floor).is_none()

@parameterized.expand([
Expand Down
10 changes: 10 additions & 0 deletions tests/reports/events/testEventReports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ def test_reportItemProperties(self):
assert_that(report_item.extra_data).is_equal_to(extra_data)
assert_that(report_item.is_accessible).is_false()
assert_that(report_item.is_companion_seat).is_false()
assert_that(report_item.has_lift_up_armrests).is_false()
assert_that(report_item.is_hearing_impaired).is_false()
assert_that(report_item.is_semi_ambulatory_seat).is_false()
assert_that(report_item.has_sign_language_interpretation).is_false()
assert_that(report_item.is_plus_size).is_false()
assert_that(report_item.has_restricted_view).is_false()
assert_that(report_item.displayed_object_type).is_none()
assert_that(report_item.parent_displayed_object_type).is_none()
Expand Down Expand Up @@ -106,6 +111,11 @@ def test_reportItemPropertiesForGA(self):
assert_that(report_item.book_as_a_whole).is_equal_to(False)
assert_that(report_item.is_accessible).is_none()
assert_that(report_item.is_companion_seat).is_none()
assert_that(report_item.has_lift_up_armrests).is_none()
assert_that(report_item.is_hearing_impaired).is_none()
assert_that(report_item.is_semi_ambulatory_seat).is_none()
assert_that(report_item.has_sign_language_interpretation).is_none()
assert_that(report_item.is_plus_size).is_none()
assert_that(report_item.has_restricted_view).is_none()
assert_that(report_item.displayed_object_type).is_none()
assert_that(report_item.parent_displayed_object_type).is_none()
Expand Down