Faster coverage-xml report #1102
Merged
+15
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1102 +/- ##
============================================
+ Coverage 88.53% 88.82% +0.29%
+ Complexity 1393 1391 -2
============================================
Files 98 98
Lines 4874 4652 -222
============================================
- Hits 4315 4132 -183
+ Misses 559 520 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Nice! Can I bother you to squash this into a single commit with a sensible commit message? |
Contributor
Author
|
here we go |
staabm
commented
Nov 5, 2025
Comment on lines
+31
to
+39
| $writer = new XMLWriter; | ||
| $writer->openMemory(); | ||
| $writer->startElementNs(null, $this->contextNode->nodeName, 'https://schema.phpunit.de/coverage/1.0'); | ||
| $writer->writeAttribute('nr', $this->line); | ||
|
|
||
| foreach ($tests as $test) { | ||
| $writer->startElement('covered'); | ||
| $writer->writeAttribute('by', $test); | ||
| $writer->endElement(); |
Contributor
Author
There was a problem hiding this comment.
my feeling is, if we would work with plain strings instead of XMLWriter we may be even faster.
is this something you would be open for?
Contributor
Author
|
I have 2 more PRs which improve processing speed in a similar way. you may want discuss them with arne: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this PR
after this PR
running my benchmark based on phpstan-src codebase recorded coverage data.
this change is based on the observation that the inlined
addTestmethod is invoked ~10 million times, when running code-coverage even on a small portion of the phpstan-src codebaseXDEBUG_MODE=coverage php tests/vendor/bin/paratest --coverage-xml=tmp/coverage-xml tests/PHPStan/Analyser