Skip to content

refactor: simplify readURLAndUpdateIcon() with early returns #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichaHuhn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: simplify readURLAndUpdateIcon() with early returns #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions StreamAwesome/src/composables/useUrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,25 @@ export function useUrl() {
readURLAndUpdateIcon()

function readURLAndUpdateIcon() {
if (params.version !== undefined) {
console.log('Found URL parameters. Trying to parse input...')
if (params.version === undefined) {
return
}

const icon = PersistenceHandler.convertPersistentIconToIcon(params)
console.log('Found URL parameters. Trying to parse input...')
const icon = PersistenceHandler.convertPersistentIconToIcon(params)

if (icon !== null) {
console.log('Successfully parsed icon from URL parameters.')
iconStore.currentIcon = icon
if (icon === null) {
console.error('Failed to parse icon from URL parameters. Trying to redirect...')
tryRedirectToMatchingVersion(params)
return
}

if (params.download !== undefined) {
downloadIcon()
console.log('Triggered icon download from URL parameters.')
}
} else {
console.error('Failed to parse icon from URL parameters. Trying to redirect...')
tryRedirectToMatchingVersion(params)
}
console.log('Successfully parsed icon from URL parameters.')
iconStore.currentIcon = icon

if (params.download !== undefined) {
downloadIcon()
console.log('Triggered icon download from URL parameters.')
}
}

Expand Down