p#479 Make sure running app is the one handling urls#5703
Merged
akleshchev merged 2 commits intodevelopfrom Apr 28, 2026
Merged
p#479 Make sure running app is the one handling urls#5703akleshchev merged 2 commits intodevelopfrom
akleshchev merged 2 commits intodevelopfrom
Conversation
akleshchev
force-pushed
the
andreyk/viewer_p479
branch
from
6a294c9 to
f693221
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure the macOS viewer that’s being launched/running re-registers itself as the URL scheme handler (e.g., secondlife://) to avoid stale Launch Services handler caching pointing to another viewer.
Changes:
- Override
LLAppViewerMacOSX::initSLURLHandler()to re-register URL schemes on startup. - Add a macOS Objective-C++ helper (
register_url_schemes) that calls Launch Services APIs to re-register the bundle and set default URL scheme handlers. - Expose the helper via
llappviewermacosx-objc.h.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| indra/newview/llappviewermacosx.h | Adds initSLURLHandler() override declaration for macOS viewer. |
| indra/newview/llappviewermacosx.cpp | Implements initSLURLHandler() and invokes URL scheme registration. |
| indra/newview/llappviewermacosx-objc.h | Exposes register_url_schemes() to C++ side. |
| indra/newview/llappviewermacosx-objc.mm | Implements Launch Services registration / default handler assignment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/viewer_p479
branch
4 times, most recently
from
7b33385 to
6a11d08
Compare
akleshchev
force-pushed
the
andreyk/viewer_p479
branch
from
6a11d08 to
7f64397
Compare
I'm not sure if viewer should actually be shutting down on this, but as a minimum we should be updating or clearing marker files. If viewer crashes because of a hibernation, it isn't our problem. Viewer isn't built for that and we can't maintain 'heartbeats' in hibernation.
akleshchev
force-pushed
the
andreyk/viewer_p479
branch
from
318f5f9 to
1eb6050
Compare
marchcat
approved these changes
Apr 27, 2026
maxim-productengine
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure running app is the one handling urls.