#5690 fix viewer trying to fetch group chat history for p2p IM#5718
Merged
maxim-productengine merged 2 commits intodevelopfrom Apr 27, 2026
Merged
#5690 fix viewer trying to fetch group chat history for p2p IM#5718maxim-productengine merged 2 commits intodevelopfrom
maxim-productengine merged 2 commits intodevelopfrom
Conversation
marchcat
approved these changes
Apr 27, 2026
akleshchev
approved these changes
Apr 27, 2026
akleshchev
reviewed
Apr 27, 2026
| } | ||
|
|
||
| // Fetch group chat history, enabled by default. | ||
| if (gSavedPerAccountSettings.getBOOL("FetchGroupChatHistory")) |
Contributor
There was a problem hiding this comment.
addMessage can be fairly frequent. Not the 'once per frame' frequent, but might be better to cache the setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't attempt to fetch chat history for p2p sessions.