Testing strategy #76

Scot3004 · 2026-02-08T03:07:00Z

Pull request

Agregados nuevos tests unitarios sobre utils
Documentada test strategy
Adicionados Test unitarios y Lint al pipeline
Renombrado pipeline de tests ya no se llama playwright
Unit se corre siempre excepto en workflow_dispatch
Eliminada dependencia dotenv (muy ruidosa) en favor de env-cmd
Playwright ya no se encarga de cargar las variables de entorno
Eslint tiene una configuración mas estricta
Actualizado codigo que se podia arreglar con eslint --fix
Warn para no explicit any, el codigo no esta preparado con buen coverage para hacer un refactor de estos

* Documentación de la estrategia de testing, incluyendo tipos de tests, herramientas y mejores prácticas. * Reorganización de pruebas unitarias * Renombrado del workflow de Playwright a "tests.yml" para reflejar mejor su propósito.

* Test A11yActions como verdadero ejemplo * Ejemplos de codigo usando alias import

El script lee el archivo.env y luego ejecuta playwright test

Ahora se instalan las siguientes extensiones * vitest * playwright * eslint

bolt-new-by-stackblitz · 2026-02-08T03:07:04Z

Run & review this pull request in StackBlitz Codeflow.

netlify · 2026-02-08T03:07:06Z

✅ Deploy Preview for secorto-astro ready!

Name	Link
🔨 Latest commit	`49a0034`
🔍 Latest deploy log	https://app.netlify.com/projects/secorto-astro/deploys/6988218c2b01d300080bd1bc
😎 Deploy Preview	https://deploy-preview-76--secorto-astro.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 100 Accessibility: 100 Best Practices: 100 SEO: 100 PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

cypress · 2026-02-08T03:09:53Z

SeCOrTo web Run #200

Run Properties: Passed #200 • 5cadfe2699: Organizados readme y copilot instruction

Project	`SeCOrTo web`
Branch Review	`pull/76/head`
Run status	`Passed #200`
Run duration	`01m 37s`
Commit	`5cadfe2699: Organizados readme y copilot instruction`
Committer	`Sergio Orozco`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`6`
View all changes introduced in this branch ↗︎

Copilot

Pull request overview

Actualiza la estrategia de testing del repo (unit con Vitest y E2E con Playwright), agrega cobertura y lint al pipeline de CI, y refuerza tooling/configuración para tests y linting en un proyecto Astro + TypeScript.

Changes:

Añade/ajusta configuración de Vitest (setup global + aliases) y nuevos unit tests para utils e i18n.
Actualiza el workflow de GitHub Actions para correr lint + unit con coverage y E2E en paralelo; renombra el workflow a “Tests”.
Elimina dotenv del setup de Playwright y documenta cómo ejecutar E2E con variables de entorno; endurece ESLint.

Reviewed changes

Copilot reviewed 32 out of 40 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
vitest.config.ts	Añade aliases y setup file para unit tests
tsconfig.json	Añade path alias `@github/*`
tests/unit/wait-netlify.fetch.test.ts	Elimina test antiguo (migrado a otra ruta)
tests/unit/utils/sectionLoader.test.ts	Nuevo unit test para sectionLoader
tests/unit/utils/rssBuilder.test.ts	Nuevo unit test para rssBuilder
tests/unit/utils/paths.test.ts	Nuevo unit test para paths utils
tests/unit/infraestructure/wait-netlify.test.ts	Ajusta imports a alias + tipado en test
tests/unit/infraestructure/wait-netlify.runner.test.ts	Corrige rutas relativas a runner/scripts
tests/unit/infraestructure/wait-netlify.run.test.ts	Ajusta imports a alias + captura exit code
tests/unit/infraestructure/wait-netlify.resolve.test.ts	Ajuste de import + cleanup más seguro de temp file
tests/unit/infraestructure/wait-netlify.print.test.ts	Ajusta imports a alias
tests/unit/infraestructure/wait-netlify.poll.test.ts	Ajusta imports a alias
tests/unit/infraestructure/wait-netlify.main.test.ts	Ajusta mocks/imports a alias
tests/unit/infraestructure/wait-netlify.fetch.test.ts	Nuevo test para guard de `fetch`
tests/unit/infraestructure/wait-netlify.ensure.test.ts	Ajusta imports a alias (con un caso restante relativo)
tests/unit/infraestructure/wait-netlify.branch.test.ts	Ajusta imports a alias
tests/unit/infraestructure/wait-netlify-validate.test.ts	Ajusta imports a alias
tests/unit/infraestructure/wait-netlify-api.test.ts	Simplifica setup/teardown y usa alias
tests/unit/i18n/utils.test.ts	Nuevos unit tests para utils i18n
tests/unit/i18n/rootMap.test.ts	Nuevos unit tests para rootMap i18n
tests/unit/i18n/buildTranslationMap.test.ts	Nuevo unit test para buildTranslationMap
tests/setup.ts	Setup global de Vitest (silenciar console + restore mocks + mock astro:content)
tests/actions/A11yActions.ts	Envuelve análisis axe en `test.step`
src/env.d.ts	Ajuste de inclusión de tipos Astro
src/content.config.ts	Reemplaza `any` por `ImageFunction` en schema helper
src/components/PostDate.astro	Ajustes de indentación/format
src/components/ListWork.astro	Ajustes de indentación/format
src/components/BlogTalkPostView.astro	Ajustes de indentación/format
playwright.config.ts	Elimina carga automática de `.env` con dotenv
package.json	Scripts nuevos E2E + elimina dotenv + agrega typescript-eslint plugin
package-lock.json	Sync lockfile (remove dotenv, engines, eslint plugin)
eslint.config.js	ESLint más estricto + typescript-eslint plugin + ignores
docs/TESTING_STRATEGY.md	Nuevo documento de estrategia de testing
cypress/e2e/stubs.ts	Ajustes de indentación + suppress de `no-explicit-any` localizado
cypress/e2e/main-page.cy.ts	Fix de bracket/indent
cypress/e2e/blog.cy.ts	Fix de bracket/indent
README.md	Documenta comandos de testing y uso de env vars en E2E
.github/workflows/tests.yml	Nuevo workflow “Tests” con unit+lint y E2E + artifacts
.github/copilot-instructions.md	Añade guía: unit tests + `@ts-check`/JSDoc para JS utilitario
.devcontainer/devcontainer.json	Actualiza Node image + extensiones recomendadas

Comments suppressed due to low confidence (2)

tests/unit/infraestructure/wait-netlify.ensure.test.ts:54

In this file, most tests import the module as @github/scripts/wait-netlify.js, but the last test imports it via a relative path (../../../.github/scripts/wait-netlify.js). Importing the same module under different specifiers can create multiple module instances and make vi.resetModules()/mocks behave inconsistently. Use the same specifier (@github/...) throughout this suite.
.github/workflows/tests.yml:36
The YAML indentation under both jobs is invalid: steps: is followed by list items (- uses, - name, etc.) at the same indentation level, but sequence items must be indented under steps: (e.g., steps:\n - ...). As written, this workflow will fail to parse and won’t run in GitHub Actions.

tests/setup.ts

vitest.config.ts

tests/unit/i18n/buildTranslationMap.test.ts

package.json

docs/TESTING_STRATEGY.md

Disabled rule import/no-unresolved and explained the reason

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 36 out of 44 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

tests/unit/infraestructure/wait-netlify.ensure.test.ts:54

This import uses a relative path (../../../.github/...) while the rest of the file uses the new @github/... alias. For consistency (and to avoid future path mistakes if the test file moves), switch this import to use @github/scripts/wait-netlify.js like the others.

README.md

.github/copilot-instructions.md

* npm run test:unit no genera cobertura * Copilot instructions tenia mal la indentation en Testing guidance * Eliminado bloque redundante when refactoring

Copilot

Pull request overview

Copilot reviewed 36 out of 44 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

tests/unit/infraestructure/wait-netlify.ensure.test.ts:54

This test imports wait-netlify.js via a deep relative path, while the rest of the suite uses the new @github/... alias. Keeping a single import style reduces path mistakes and ensures the Vitest/TS alias configuration is actually exercised. Consider switching this import to @github/scripts/wait-netlify.js for consistency.

Copilot · 2026-02-08T05:37:22Z

README.md

+
+| Command             | Acción                                                           |
+| :------------------ | :--------------------------------------------------------------- |
+| `npm run test`      | Ejecuta las pruebas E2E (Playwright/Cypress según configuración) |


The new Tests section says npm run test runs E2E tests with “Playwright/Cypress”, but package.json currently defines test as cypress run. Either update the documentation to match the current command behavior, or change the test script to reflect the intended default E2E runner.

Suggested change

| `npm run test` | Ejecuta las pruebas E2E (Playwright/Cypress según configuración) |

| `npm run test` | Ejecuta las pruebas E2E con Cypress (`cypress run`) |

docs/TESTING_STRATEGY.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Scot3004 added 18 commits February 7, 2026 18:07

Vitest alias

4716df3

Documentada testing strategy

a91cd4e

* Documentación de la estrategia de testing, incluyendo tipos de tests, herramientas y mejores prácticas. * Reorganización de pruebas unitarias * Renombrado del workflow de Playwright a "tests.yml" para reflejar mejor su propósito.

Refinado de testing strategy

cc714b3

* Test A11yActions como verdadero ejemplo * Ejemplos de codigo usando alias import

Eliminado dotenv en favor de bash

e38b0d5

Creado npm script test:e2e:env

879a401

El script lee el archivo.env y luego ejecuta playwright test

Actualización del devcontainer

273f6e0

Ahora se instalan las siguientes extensiones * vitest * playwright * eslint

Instrucciones para correr e2e en devcontainer

eaaf003

Preset eslint typescript recommended

8bd9edd

Fix para lo que se puede arreglar con --fix

7fe4e0c

Allow _ variables

b93e8ae

vitest setup for all mocks

0321a79

Silenciar consola en tests

b8ce3d0

Tests sobre la carpeta i18n

bfae091

Imports de utils en tests, eliminado stubFetch sin uso

85702d1

Simplificado test ensureFetch

922107f

content config type imageFunction

e365861

Eslint CI

474c092

Removed as typeof fetch

49dc0d9

Scot3004 requested a review from Copilot February 8, 2026 03:07

Copilot started reviewing on behalf of Scot3004 February 8, 2026 03:07 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

Scot3004 and others added 6 commits February 7, 2026 22:15

Disable eslint on env.d.ts

8d9cb72

Disabled rule import/no-unresolved and explained the reason

Apply suggestions from code review

bd10449

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix for pr comments and lint error

db1751c

Organizado documento test strategy basado en comentarios

0d45be9

Eliminación any buildTranslationsMap

adcbf50

Language picker tests y utils

22e39ef

Available locales interface

fc48216

Scot3004 requested a review from Copilot February 8, 2026 05:12

Copilot started reviewing on behalf of Scot3004 February 8, 2026 05:12 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

README.md Outdated Show resolved Hide resolved

.github/copilot-instructions.md Outdated Show resolved Hide resolved

.github/copilot-instructions.md Outdated Show resolved Hide resolved

Organizados readme y copilot instruction

5cadfe2

* npm run test:unit no genera cobertura * Copilot instructions tenia mal la indentation en Testing guidance * Eliminado bloque redundante when refactoring

Scot3004 requested a review from Copilot February 8, 2026 05:32

Copilot started reviewing on behalf of Scot3004 February 8, 2026 05:32 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

Update docs/TESTING_STRATEGY.md

49a0034

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Scot3004 merged commit c8d6ef3 into master Feb 8, 2026
6 of 7 checks passed

Scot3004 deleted the testing-strategy branch February 8, 2026 05:39

	\| `npm run test` \| Ejecuta las pruebas E2E (Playwright/Cypress según configuración) \|
	\| `npm run test` \| Ejecuta las pruebas E2E con Cypress (`cypress run`) \|

Testing strategy #76

Testing strategy #76

Uh oh!

Conversation

Scot3004 commented Feb 8, 2026

Pull request

Uh oh!

bolt-new-by-stackblitz bot commented Feb 8, 2026

Uh oh!

netlify bot commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for secorto-astro ready!

Uh oh!

cypress bot commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SeCOrTo web Run #200

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

netlify bot commented Feb 8, 2026 •

edited

Loading

cypress bot commented Feb 8, 2026 •

edited

Loading