Conversation
|
|
✅ Deploy Preview for secorto-astro ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SeCOrTo web
|
||||||||||||||||||||||||||||
| Project |
SeCOrTo web
|
| Branch Review |
pull/79/head
|
| Run status |
|
| Run duration | 01m 35s |
| Commit |
|
| Committer | Sergio Orozco |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
6
|
| View all changes introduced in this branch ↗︎ | |
Contributor
There was a problem hiding this comment.
Pull request overview
Este PR habilita el uso de la URL base configurada en Astro (import.meta.env.SITE) para evitar hardcodear el dominio en distintas partes del sitio.
Changes:
- Amplía
tsconfig.jsonpara excluirnode_modulesyplaywright-reportdel análisis de TypeScript. - Actualiza el RSS para tomar el
sitedesdeimport.meta.env.SITE(como fallback decontext.site). - Reemplaza URLs absolutas hardcodeadas en canonical/hreflang y en el Footer para usar
import.meta.env.SITE.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tsconfig.json | Excluye artefactos adicionales (node_modules, playwright-report) del scope de TS. |
| src/pages/rss.xml.ts | Usa import.meta.env.SITE como base URL para el RSS cuando context.site no esté disponible. |
| src/pages/[locale]/[section]/[...id].astro | Genera canonical y hreflang basados en import.meta.env.SITE en vez de un dominio fijo. |
| src/components/Footer.astro | Cambia el link del nombre del autor para apuntar al site configurado. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Habilta el uso de import.meta.env.SITE