CloudLogServiceFactory & ValidationUtil & HttpUtils 代码优化#301
Open
MiKKiYang wants to merge 4 commits intosecretflow:mainfrom
Open
CloudLogServiceFactory & ValidationUtil & HttpUtils 代码优化#301MiKKiYang wants to merge 4 commits intosecretflow:mainfrom
MiKKiYang wants to merge 4 commits intosecretflow:mainfrom
Conversation
Signed-off-by: MikkiYang <hecy7@asiainfo.com>
Signed-off-by: MikkiYang <hecy7@asiainfo.com>
Signed-off-by: MikkiYang <hecy7@asiainfo.com>
Signed-off-by: MikkiYang <hecy7@asiainfo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValidationUtil ：每次调用都获取新 Validator 实例，Validator虽是线程安全的，但频繁创建影响性能
CloudLogServiceFactory ：无需多次重复调用getter方法
HttpUtils：完善客户端读写超时、IpFilterUtil对应Bean单例初始化