Web generator/Single card changes#7
Open
Latent-Logic wants to merge 9 commits intosecretshipfic:masterfrom
Open
Web generator/Single card changes#7Latent-Logic wants to merge 9 commits intosecretshipfic:masterfrom
Latent-Logic wants to merge 9 commits intosecretshipfic:masterfrom
Conversation
The "earth pony" string is the only one that used a space. Add a second entry in the dictionary to allow "earthpony" to be used as well for consistency
Most of the logic came from @coandco https://github.com/coandco/CardMachine/tree/web_generator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the majority of the changes from the coandco:web_generator branch that are generally applicable. I've left out the php interface as that's only useful for the TSSSF-Frontend system.
None of these changes should break the workflow of building many cards, but I've not tested that as our system uses the new
single_card.pyoption exclusively. Please test and merge if these improvements are wanted.