Updated to work with current Python, Pillow, and ImageMagick#8
Open
DasKatzchen wants to merge 11 commits intosecretshipfic:masterfrom
Open
Updated to work with current Python, Pillow, and ImageMagick#8DasKatzchen wants to merge 11 commits intosecretshipfic:masterfrom
DasKatzchen wants to merge 11 commits intosecretshipfic:masterfrom
Conversation
Should bring me up to date.
Replace all print statements and cast floats to ints for PIL. PDF generation still broken, IM convert doesn't like something about the format. That's next on my list but it runs now so I'll take what I can get. Also added all card repositories as submodules
Fixing this was easier than I though. Once I figured out that it was doubling up the path, was easily able to fix it. Could refactor all uses of card_set to more accurately deal with subfolders but... the PDF creation was the only spot where it matters, so I just kludged in an os.path.basename() and was done with it.
Merge branch submodules
This makes it work on both both Windows and Linux, since Windows is slash-agnostic
As that is the branch I primarily work with
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought CardMachine screaming into the modern age. Replaced all print functions to work with Python 3, cast some float coordinates as ints to work with Pillow, updated the PDF creation command to use 'magick convert' instead of 'convert' (and also fixed the command to handle subdirectories properly). In addition, I've added all the other necessary repositories as submodules, note that secretshipfic/Card-Art#2 and secretshipfic/TSSSFTemplates#3 are necessary for this to work.