Skip to content

fix(aarch64): pull Chromium patch to assume nightly rustc #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RKNF404 merged 2 commits into from
Feb 12, 2026
+36 −1
Merged

fix(aarch64): pull Chromium patch to assume nightly rustc #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f028202
fix(aarch64): pull Chromium patch to assume nightly rustc
RoyalOughtness Feb 11, 2026
4c1ae92
Merge branch 'live' into upstreamrustpatch
RKNF404 Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build/trivalent.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,6 @@ CHROMIUM_GN_DEFINES+=" clang_use_chrome_plugins=false"
CHROMIUM_GN_DEFINES+=" rust_sysroot_absolute=\"$(rustc --print sysroot)\""
CHROMIUM_GN_DEFINES+=" rust_bindgen_root=\"$rust_bindgen_root\""
CHROMIUM_GN_DEFINES+=" rustc_version=\"$(rustc --version)\""
CHROMIUM_GN_DEFINES+=" rustc_nightly_capability=true"
CHROMIUM_GN_DEFINES+=" chrome_pgo_phase=0"
%endif
CHROMIUM_GN_DEFINES+=' system_libdir="%{_lib}"'
Expand Down
36 changes: 36 additions & 0 deletions chromium_patches/0003-Assume-rustc-is-nightly-if-building-Chromium.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
From 272bb673e5a2665321b7a62cbf75f58e60130c5d Mon Sep 17 00:00:00 2001
From: LN Liberda <lauren@selfisekai.rocks>
Date: Tue, 20 Jan 2026 13:00:55 -0800
Subject: [PATCH] Assume rustc is nightly if building Chromium
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Nightly is required to build full Chromium.
This variable was introduced to build just V8 with ancient Rust,
and is mostly used to bring incompatibilities with current Rust versions.

Bug: none
Change-Id: Ie652a7af8414aac5d7dc7cf9f1c27f04b5ed1034
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7492958
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1571838}
---
build/config/rust.gni | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build/config/rust.gni b/build/config/rust.gni
index 36a1fdd350f4ac..f88d57f45996cb 100644
--- a/build/config/rust.gni
+++ b/build/config/rust.gni
@@ -121,7 +121,7 @@ use_chromium_rust_toolchain = rust_sysroot_absolute == ""
# `rustc_nightly_capability = false` will make the build avoid the use of
# Rust nightly features. There are no bots that test this and there is no
# guarantee it will work, but we accept patches for this configuration.
-rustc_nightly_capability = use_chromium_rust_toolchain
+rustc_nightly_capability = use_chromium_rust_toolchain || build_with_chromium

# Platform support for the Rust toolchain.
chromium_toolchain_supports_platform = !is_wasm