Skip to content

input validation to prevent RCE; github isssue #245 #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkoumis merged 1 commit into from
Sep 18, 2025
Merged

input validation to prevent RCE; github isssue #245 #246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/dalton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,6 +799,15 @@ def sensor_request_job():
# @auth_required('write')
def post_job_results(jobid):
"""called by Dalton Agent sending job results"""

if not validate_jobid(jobid):
logger.error(f"Bad jobid given: '{jobid}'. Possible hacking attempt.")
return Response(
"Error: Invalid Job ID",
mimetype="text/plain",
headers={"X-Dalton-Webapp": "Error"},
)

# no authentication or authorization so this is easily abused; anyone with jobid
# can overwrite results if they submit first.
redis = get_redis()
Expand Down