fix(health): fix issue where chain id wasn't cached#98
Open
FranklinWaller wants to merge 1 commit intomainfrom
Open
fix(health): fix issue where chain id wasn't cached#98FranklinWaller wants to merge 1 commit intomainfrom
FranklinWaller wants to merge 1 commit intomainfrom
Conversation
kaynetik
approved these changes
Mar 25, 2026
Member
|
I'm not sure if this entirely correct, because now the health check doesn't actually verify that the proxy can reach the chain in future health checks. Maybe wrap it in a cache with TTL until we have time to properly think of how to do a health check mechanism that harmonises core and Fast? |
…t using the chain
FranklinWaller
force-pushed
the
patch/broken-health-api
branch
from
aa88d20 to
48cdfbb
Compare
Member
Author
|
@Thomasvdam I changed it to do without caching because we do indeed want to know which proxies are unhealthy. Instead i've opted for just the fastOnly flag. Then the health endpoint won't return a unhealthy status when the chain is upgrading. |
Member
Author
|
Also made the better effect version, this is just a hotfix |
Thomasvdam
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
(Write your motivation here)
Explanation of Changes
(Write your explanation here)
Testing
(Write your test plan here)
Related PRs and Issues
(Link your related PRs and Issues here)