Skip to content

Conversation

signekb
Copy link
Member

@signekb signekb commented Sep 23, 2025

Description

This adds a landing page to the website. This is a first draft and I'm a bit out of touch with this package, so let me know if something's off :)

Closes #8

Needs an in-depth review.

Checklist

  • Formatted Markdown
  • Ran just run-all

@signekb signekb requested a review from a team as a code owner September 23, 2025 08:25
@lwjohnst86 lwjohnst86 moved this from Todo to In Review in Iteration planning Sep 23, 2025
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 😁 very minor edit

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Sep 23, 2025
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
@signekb signekb requested a review from lwjohnst86 September 23, 2025 11:05
@signekb signekb moved this from In Progress to In Review in Iteration planning Sep 23, 2025
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change to descriptor and add your comments, then I'll approve 👍

@lwjohnst86 lwjohnst86 moved this from In Review to In Progress in Iteration planning Sep 23, 2025
@signekb signekb requested a review from lwjohnst86 September 23, 2025 13:38
Copy link
Contributor

@martonvago martonvago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely written! Just super minor things

- Provides clear and user-friendly messages that point directly to
where issues occur in the descriptor.
- Supports a strict mode that enforces full compliance with the
standard, including all recommended fields.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
standard, including all recommended fields.
standard, including all recommended rules.

Or "checks"? Because we're not talking about the fields but constraints on those fields

Copy link
Member Author

@signekb signekb Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
standard, including all recommended fields.
standard, including all recommended values.

Values maybe? or property values?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "checks" might be better here. The recommendations are for the existence of properties. (ones with SHOULD or MAY language in the standard).

Copy link
Member Author

@signekb signekb Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked into it and, as far as I understand now, the recommendations are actually both for the existence of properties (e.g., "A Data Package descriptor [...] SHOULD have name, id, licenses, and profile properties.") and for the values of those properties (e.g., "It [the name] SHOULD be human-readable and consist only of lowercase English alphanumeric characters plus ., - and _.") (both quotes are from the description of the Data Package.

So, it depends on what the strict mode actually does: Does it both check for the existence of the recommended properties and for the values of those properties?

I don't like "check" bc it feels unspecific. Could an alternative be (if strict mode does both things described above):

Suggested change
standard, including all recommended fields.
standard, including checking the existence of all recommended properties and their recommended values.

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also just be:

Suggested change
standard, including all recommended fields.
standard, including all recommendations.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion by @martonvago

Co-authored-by: martonvago <57952344+martonvago@users.noreply.github.com>
@signekb signekb moved this from In Progress to In Review in Iteration planning Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

Add a landing page to website
3 participants