refactor: ♻️ simplify handling of grouped errors #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonvago
commented
Sep 23, 2025
lwjohnst86
reviewed
Sep 23, 2025
lwjohnst86
requested changes
Sep 29, 2025
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
martonvago
commented
Sep 29, 2025
martonvago
commented
Sep 29, 2025
martonvago
commented
Sep 29, 2025
martonvago
commented
Sep 29, 2025
We can merge it in if you like this approach! I just wasn't sure if anyone had a better idea for dealing with all the custom mapping. There will be 15 cases all in all, so that will require lots of rather specific and arcane code. |
lwjohnst86
requested changes
Sep 29, 2025
martonvago
commented
Oct 6, 2025
lwjohnst86
requested changes
Oct 7, 2025
martonvago
commented
Oct 8, 2025
martonvago
commented
Oct 8, 2025
martonvago
commented
Oct 8, 2025
lwjohnst86
requested changes
Oct 9, 2025
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
lwjohnst86
changed the title
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors how the grouped errors listed in #15 could be simplified.
It adds custom logic for the first 2 items in the list.
We will probably be able to share quite a bit of code between the various error cases, this is just a start.
Needs an in-depth review.
Checklist
just run-all