This repository was archived by the owner on Nov 1, 2021. It is now read-only.
Fix/tracking#94
Open
danchyy wants to merge 4 commits intoseemethere:masterfrom
Open
Conversation
…given, default is used
…hether passing and tracking stats are correct
Author
|
Hey everyone, I created this Pull request, I'm wondering if anyone took a look at this, because I don't know what's the problem with this PR. I hope that it could get merged, since I believe it could be of a good use in current package, as Tracking stats are quite valuable. |
pmazgaj
reviewed
Jan 17, 2018
| @@ -0,0 +1,32 @@ | |||
| from nba_py import league | |||
There was a problem hiding this comment.
In my opinion, rewriting it to UnitTests usage would be a great idea.
pmazgaj
approved these changes
Jan 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added option to correctly fetch stats for tracking of players which were lacking before, it was only available for speed.