Allow overriding of lifetime#298
Open
samcragg wants to merge 1 commit intoseesharper:masterfrom
samcragg:master
Open
Allow overriding of lifetime#298samcragg wants to merge 1 commit intoseesharper:masterfrom samcragg:master
samcragg wants to merge 1 commit intoseesharper:masterfrom
samcragg:master
Conversation
Changed where the processing of overrides happens to allow the selection of the emit method to happen after the service request has been updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have an issue where we're scanning the assemblies but certain types that implement an interface have to be registered as PerContainerLifetime. We got around it by scanning the assemblies twice using the overloads with a predicate, however, looked like a simple change could be made to allow the Override method to be used.
Hope it's ok - let me know if you want me to make any changes.