Skip to content

Escape import collaboration filename values#46

Open
moksha-hub wants to merge 1 commit intoseetadev:mainfrom
moksha-hub:escape-import-filename-template
Open

Escape import collaboration filename values#46
moksha-hub wants to merge 1 commit intoseetadev:mainfrom
moksha-hub:escape-import-filename-template

Conversation

@moksha-hub
Copy link
Copy Markdown

Summary

  • render filename/session values with the correct Jinja escaping for HTML and JavaScript contexts
  • move filename usage in inline scripts to a tojson-encoded variable instead of raw template interpolation
  • escape the filename before inserting it into dynamically generated input HTML and URL-encode it for /runas

Verification

Fixes #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security][Critical] Stored XSS via Unsanitized Filename Injected into JavaScript Context in importcollabload.html

1 participant