Prachi/add invoice validation#49
Open
Prachi01Yadav wants to merge 3 commits intoseetadev:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a robust client-side validation layer to the invoice saving workflow. By implementing a dedicated InvoiceValidator service, the application now prevents the creation of "ghost" records (empty invoices) and ensures data integrity before any local or cloud-based storage operations occur.
Key Changes:
New Service: Created src/services/InvoiceValidator.ts to centralize validation logic, including checks for empty content, minimum data length, and reserved filenames (e.g., "default").
Menu Integration: Updated src/components/Menu/Menu.tsx to intercept Save and Save As actions. The UI now provides immediate feedback via IonToast if validation fails.
User Experience: Added warnings for short filenames and missing invoice numbers to encourage better record-keeping habits.