fix: add validation to prevent saving empty or incomplete invoices#50
Open
Mikey3600 wants to merge 1 commit intoseetadev:mainfrom
Open
fix: add validation to prevent saving empty or incomplete invoices#50Mikey3600 wants to merge 1 commit intoseetadev:mainfrom
Mikey3600 wants to merge 1 commit intoseetadev:mainfrom
Conversation
- Added empty content check in doSave() before saving - Added empty content check in doSaveAs() before saving - Shows toast message 'Cannot save an empty invoice!' to user - Fixes seetadev#48
Open
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #48
Adds validation to prevent users from saving empty or incomplete invoices in both Save and Save As workflows.
Changes
doSave()before saving — shows toast message if invoice is emptydoSaveAs()before saving — same validation applied consistentlyTesting
PR Category