Skip to content

Conversation

@sayan-das-in
Copy link
Contributor

@sayan-das-in sayan-das-in commented Nov 26, 2025

This PR addresses two changes for LR and TTD

  • Migrates to AWS S3 Client instead of custom S3 upload library
  • Adds a tag to the S3 file chunks representing number of rows in that file, this will be used downstream to emit Observability Metrics

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Staging tests

Liveramp Delivery from monoservice

image ### Row count tag image

Trade-Desk Delivery from monoservice

image

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

@sayan-das-in sayan-das-in changed the title Migrate LR and TTD to use AWS S3 Client LR and TTD - Migrate to AWS S3 Client and add row_count Tags Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.00%. Comparing base (8b60ac8) to head (9fe0b8f).

Files with missing lines Patch % Lines
...s/src/destinations/the-trade-desk-crm/awsClient.ts 37.50% 5 Missing ⚠️
...s/src/destinations/the-trade-desk-crm/functions.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3440      +/-   ##
==========================================
- Coverage   80.04%   80.00%   -0.04%     
==========================================
  Files        1224     1224              
  Lines       22705    22706       +1     
  Branches     4503     4499       -4     
==========================================
- Hits        18175    18167       -8     
- Misses       3699     3709      +10     
+ Partials      831      830       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants