Skip to content

Applying patch for LIBRARIES-2720 #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
package com.segment.analytics.gson;

import com.google.gson.*;
import com.google.gson.stream.JsonReader;
import com.google.gson.stream.JsonWriter;
import java.io.IOException;
import java.lang.reflect.Type;
import java.time.Instant;

/**
* A {@link JsonSerializer} that formats {@link Instant} objects into iso8601 formatted strings, and
* {@link JsonDeserializer} that parses iso8601 formatted strings into {@link Instant} objects.
*/
public class ISO8601InstantAdapter extends TypeAdapter<Instant>
implements JsonSerializer<Instant>, JsonDeserializer<Instant> {
@Override
public JsonElement serialize(Instant src, Type typeOfSrc, JsonSerializationContext context) {
return new JsonPrimitive(Iso8601Utils.format(src)); // ISO 8601 format
}

@Override
public Instant deserialize(JsonElement json, Type typeOfT, JsonDeserializationContext context)
throws JsonParseException {
return Instant.parse(json.getAsString());
}

@Override
public void write(JsonWriter out, Instant value) throws IOException {
out.value(value == null ? null : value.toString());
}

@Override
public Instant read(JsonReader in) throws IOException {
String str = in.nextString();
return str == null ? null : Instant.parse(str);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
package com.segment.analytics.gson;

import com.google.gson.JsonParseException;
import java.time.Instant;
import java.util.Calendar;
import java.util.Date;
import java.util.GregorianCalendar;
Expand Down Expand Up @@ -277,4 +278,10 @@ private static int indexOfNonDigit(String string, int offset) {
}
return string.length();
}

/** Returns {@code date} formatted as yyyy-MM-ddThh:mm:ss.sssZ */
static String format(Instant instant) {
// Format the instant
return String.valueOf(instant.getEpochSecond());
}
}
3 changes: 3 additions & 0 deletions analytics/src/main/java/com/segment/analytics/Analytics.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@
import com.google.gson.GsonBuilder;
import com.segment.analytics.gson.AutoValueAdapterFactory;
import com.segment.analytics.gson.ISO8601DateAdapter;
import com.segment.analytics.gson.ISO8601InstantAdapter;
import com.segment.analytics.http.SegmentService;
import com.segment.analytics.internal.AnalyticsClient;
import com.segment.analytics.internal.AnalyticsVersion;
import com.segment.analytics.messages.Message;
import com.segment.analytics.messages.MessageBuilder;
import java.time.Instant;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
Expand Down Expand Up @@ -362,6 +364,7 @@ public Analytics build() {

gsonBuilder
.registerTypeAdapterFactory(new AutoValueAdapterFactory())
.registerTypeAdapter(Instant.class, new ISO8601InstantAdapter())
.registerTypeAdapter(Date.class, new ISO8601DateAdapter());

Gson gson = gsonBuilder.create();
Expand Down