Allow setting Set ConsumerGroupConfig.Timeout from ReaderConfig #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a reader is used to do an explicit Commit, there wasn't any way to specify the ConsumerGroupConfig.Timeout that was being used for the operation. With this change, we can set ReaderConfig.Timeout and have it copied over to the ConsumerGroupConfig when that is created from the ReaderConfig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a reader is used to do an explicit Commit, there wasn't any way to specify the ConsumerGroupConfig.Timeout that was being used for the operation.
With this change, we can set ReaderConfig.Timeout and have it copied over to the ConsumerGroupConfig when that is created from the ReaderConfig.