feat(wsprotocol): implement shared phase-1 WebSocket protocol structs and validation#179
Merged
feat(wsprotocol): implement shared phase-1 WebSocket protocol structs and validation#179
Conversation
… and validation Go protocol package with: - Envelope, OutputPayload, FinalPayload structs and JSON tags - Envelope.Validate(), OutputPayload.Validate(), FinalPayload.Validate() - AckPayload/ErrorPayload builders and MessageTracker/OutputSequenceTracker for dedup and gap handling - DecodePayload generic helper for typed payload extraction - IsSupportedType, isTaskType, isExecutionType helpers Test: message_test.go and ack_sequence_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement the Go side of the shared phase-1 WebSocket protocol contract. Pure structs, validators, and helpers — no transport or behaviour changes to existing HTTP polling/result reporting.
Changes
internal/wsprotocol/message.go—Envelopestruct with JSON tags (protocol_version,message_id,type,agent_id,task_id,execution_attempt_id,sequence,sent_at,payload),OutputPayloadandFinalPayloadstructs, all type/stream/status constants,Validate()methods on each,DecodePayload[T]generic helper,IsSupportedTypehelpersinternal/wsprotocol/ack_sequence.go—AckPayload/ErrorPayloadstructs with builders,MessageTracker(dedup bymessage_id),OutputSequenceTracker(per-stream monotonic sequencing — accepts contiguous, re-ACKs duplicates, rejects gaps as retryable)message_test.go(8 tests: JSON round-trip, type catalog, envelope validations, payload validations) andack_sequence_test.go(8 tests: ack/error shapes, duplicate IDs, contiguous/duplicate/gap sequences, stream independence, canonical field-name locking)Validation