Conversation
…polling through enqueue, separate durable start from transport start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
TaskJobto decouple task receipt from execution so polling fallback and WebSocket delivery share one runner queue. Also splits the started lifecycle so durable local-state persistence happens before process launch, separate fromtask.startedtransport emission.Changes
processTaskdirectly; every task passes throughEnqueueinto one sequential runner looptaskExecutor, notTaskJob; polling and WS tasks share the same execution pathreserveAttempt/finishAttemptkeyed bytask_id + execution_attempt_idResultChannel.RecordStartedpersists running state before process launch;SendStartedonly emits the transport messageRecordStartedadded,SendStartedslimmed to transport-onlyTaskJobReporterintegration tests updated for async runner modelTesting
Note
This PR includes the uncommitted ws-task-delivery changes that were in the working tree. The effective runner-refactor change is best reviewed as the diff from the
ws-push-task-deliverybase.