feat(ws): add polling fallback rollout controls#186
Merged
Conversation
…ello capability exchange, and overlap suppression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add independent rollout flags, effective delivery gating via hello handshake, polling pause/resume coordination, and duplicate-execution safety during polling/WS overlap transitions.
Changes
Hostlink
HOSTLINK_WS_RESULTS_ENABLED,HOSTLINK_WS_DELIVERY_ENABLED,HOSTLINK_WS_POLLING_FALLBACK_THRESHOLD, plusparseBoolEnabledhelperrollout.Coordinatortracks effective delivery state, drives polling gate and timeout-based fallbackagent.hello.payload.capabilities(results_enabled, delivery_enabled),agent.hello_ack.payload.delivery_enabledwith reconciliation directivestask.deliverwhen disabled, skip result channel when results disabled, preserve HTTP fallbackPollingGateinterface suppresses fetch when coordinator says polling not neededRails
AgentWebsocketRolloutPolicywith env-backed gateway/delivery enablement + optional canary allowlists by agent/org PIDdelivery_enabledfrom hostlink capabilities + server policy, includes inagent.hello_ackAgentsController#indexreturns same-agent leased pending tasks withexecution_attempt_id; foreign active leases hiddenDuplicate Safety
task_id + execution_attempt_id, plustask_idfallback during polling/WS overlap windowsDocs
SPEC.md,specs/10-polling-fallback-rollout.md,.context/agents-and-heartbeats.mdwith actual flag names and fallback rules