fix(deps): use correct rosdep key for SQLite3#250
Merged
mfaferek93 merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ros2_medkit_fault_manager’s rosdep dependency so the ROS buildfarm installs the SQLite3 development headers/library required by the package’s CMake configuration (find_package(SQLite3 REQUIRED)).
Changes:
- Replace
sqlite3rosdep key withlibsqlite3-devinros2_medkit_fault_manager/package.xml.
Change `sqlite3` to `libsqlite3-dev` in fault_manager package.xml. The `sqlite3` key maps to the CLI tool, not the development headers and library needed for compilation. Fixes #249
mfaferek93
force-pushed
the
fix/sqlite-rosdep-key
branch
from
ea3de88 to
fd56b04
Compare
bburda
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlite3→libsqlite3-devrosdep key inros2_medkit_fault_manager/package.xmlBuildfarm job
Jdev__ros2_medkit__ubuntu_noble_amd64fails becausesqlite3rosdep key installs the CLI tool, not the dev headers/library needed forfind_package(SQLite3 REQUIRED).Build log: https://build.ros2.org/job/Jdev__ros2_medkit__ubuntu_noble_amd64/1/display/redirect
Test plan
Fixes #249