Open
Conversation
- added support to add class to card '.selected' which will also increate the bottom distance. - created scss support with configuration at the top - created bower package so that css-playing-cards can be found on bower. Just need to register the package here http://bower.io/docs/creating-packages/#register
Owner
|
Thanks, this sounds generally good. |
Author
|
I appreciate it. I'm really glad I found your project, it was very useful and a pleasure to work with. Since I extended it a bit with sass, and for use on mobile; I figured it would be nice to contribute those changes back. I will compare the outputs of the scss file and compare it against the existing cards.css to identify any differences, I'm thinking that will make it easier to review my additions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used your library in my cribbage game https://github.com/lpaulger/cribbage-the-game and I wanted to contribute my changes to this library to the official package. Below are my changes, please review them.
I also thought it would be awesome to add this package to bower, so users can install straight from the bower package manager. I've included the bower.json configuration file (please review) and if its ok, then the only thing left to do is register the package on bower (http://bower.io/docs/creating-packages/#register). I really appreciate your effort on this lib :)
Changes:
increate the bottom distance.
Just need to register the package here
http://bower.io/docs/creating-packages/#register