Skip to content

fix: resolve workspace:* protocol to enable npm install#62

Merged
WellDunDun merged 4 commits intomainfrom
custom/prefix/router-1773675884536
Mar 16, 2026
Merged

fix: resolve workspace:* protocol to enable npm install#62
WellDunDun merged 4 commits intomainfrom
custom/prefix/router-1773675884536

Conversation

@WellDunDun
Copy link
Collaborator

Summary

Replace the workspace:* dependency protocol with file: to fix npm install failures. The workspace protocol is a bun/pnpm monorepo feature that npm doesn't understand, causing EUNSUPPORTEDPROTOCOL errors on every npm install -g selftune.

Since the telemetry-contract package is already bundled in the tarball via the files array, using the file: protocol allows both bun and npm to resolve it correctly. This is a one-line fix with no import changes needed.

Verification

  • ✅ All 1380 tests pass
  • ✅ npm pack generates valid tarball with telemetry-contract files
  • ✅ npm install from tarball succeeds (v0.2.5: 2 packages, 0 vulnerabilities)
  • ✅ bun install continues to work normally

Files Changed

  • package.json: workspace:* → file:packages/telemetry-contract
  • bun.lock: regenerated to reflect new resolution

WellDunDun and others added 3 commits March 16, 2026 18:47
The workspace:* dependency on @selftune/telemetry-contract breaks
npm install because npm doesn't understand the workspace protocol.
Using file: instead works with both bun and npm since the package
is already bundled in the tarball via the files array.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: db5e4d15-3373-4fe3-9688-d6e1b297c373

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Package version bumped from 0.2.5 to 0.2.6. Dependency resolution for @selftune/telemetry-contract changed from workspace protocol to local file reference.

Changes

Cohort / File(s) Summary
Package Configuration
package.json
Version increment (0.2.5 → 0.2.6) and @selftune/telemetry-contract dependency shifted from workspace:* to local file:packages/telemetry-contract reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title follows conventional commits format (fix:) and accurately describes the main change: resolving workspace:* protocol for npm install compatibility.
Description check ✅ Passed The PR description comprehensively documents the problem, solution, rationale, and verification steps directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch custom/prefix/router-1773675884536
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

…lure

The merge created a duplicate @selftune/telemetry-contract entry in
bun.lock (both workspace: and file: variants), which caused bun to
fail module resolution in CI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@WellDunDun WellDunDun merged commit cfb874e into main Mar 16, 2026
8 checks passed
@WellDunDun WellDunDun deleted the custom/prefix/router-1773675884536 branch March 16, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant