Conversation
Adds a `preferReverse` option for sets to prioritize `FLAT_SILVER+REVERSE` foil variants when multiple types exist for a card. Includes a workaround to correctly resolve asset paths for these specific variants. Improves asset loading robustness by adding detailed console warnings and user-facing toast notifications for failed texture loads (front, mask, foil), ensuring the loading process completes gracefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a new shader to handle flat silver reverse holos, which are prominent in ASC ascended heroes. For now only one holo foil variant is shown even though up to 3x cards are available in the set.
Related Issue
Closes #12
Checklist
bun run lintpassesbun test:unitpassesbun test:shaderpasses (if shaders were modified)