Skip to content

fix: improve error handling in toBigInt function #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Galoretka
Copy link
Contributor

Fix TypeError when error.message is undefined by using optional chaining
and fallback to error.toString() for safer error handling.

Copy link
Contributor

@JohnGuilding JohnGuilding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @Galoretka. One small suggestion

Co-authored-by: John Guilding <54913924+JohnGuilding@users.noreply.github.com>
@Galoretka
Copy link
Contributor Author

Cheers @Galoretka. One small suggestion

Done

@Galoretka Galoretka requested a review from JohnGuilding August 7, 2025 12:31
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you very much @Galoretka

@vplasencia vplasencia merged commit 820f34a into semaphore-protocol:main Aug 7, 2025
4 checks passed
Copy link

gitpoap-bot bot commented Aug 7, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Semaphore Contributor:

GitPOAP: 2025 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants