This repository was archived by the owner on Oct 28, 2025. It is now read-only.
Open
Conversation
flaper87
reviewed
Jul 10, 2025
flaper87
reviewed
Jul 10, 2025
| if config: | ||
| args.extend(["--config", config]) | ||
| args.append(temp_dir) | ||
| args = ["ci", "--json", "--dry-run"] # avoid the extra exec |
Collaborator
There was a problem hiding this comment.
Can you share why ci is preferred here over scan?
Also, why is --dry-run needed?
Collaborator
Author
There was a problem hiding this comment.
Currently, you can't run a supply chain scan with scan, so we have to use ci in this case. We add --dry-run in so that the scan completes and reports findings locally in a json blob, but does not upload the findings to the cloud platform.
Collaborator
There was a problem hiding this comment.
A-ha, I see! Thanks. All clear.
The --dry-run name is a bit confusing, but it makes sense 🤣
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for supply-chain and secrets scanning
This PR updates the semgrep scan functionality to support different scan types:
scantociwith--dry-runscan_typeparameter with three options:code: Standard code scanning (default)supply-chain: For scanning dependencies and CI/CD configurationssecrets: For detecting secrets in code--includeinstead of positional arguments