Add Cartan matrix computation for monoids #1048
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To update your branch to the latest
|
JosephDayngerRuiz
force-pushed
the
AddingCartan
branch
from
86d0dcf to
e7eb3e4
Compare
|
Try doing: |
Removed empty space. Added header. Change line endings to LF
Added a header.
Added comments making the simple calculation clearer.
Reclarified the computation for the bicharater of the radical.
Method to display the character table was added.
Moved some xml documentation
Removed white space
The purpose of changing the Cartan matrix into a object is to allow a display method of the Cartan matrix to be separate from the character table.
Moved the documentation from the code to a separate xml
Created a category for monoid Cartan matrices and moved the PIMS from the character table to the Cartan matrix
Added a cartan matrix object and a viewstring and displaystring for said object.
Correcting the documentation. Needs another correction too.
I learned how to make a proper test file.
Implemented gaplint to help with code standardization.
Added local variable to the test.
Changed the file to match the style recommended for the semigroup package.
Added test for more functions in the project. I was reminded that the current implementation does not work for groups.
Continuing to lint and plan the addition of the finite field code.
james-d-mitchell
requested changes
Apr 11, 2025
There was a problem hiding this comment.
Thanks @JosephDayngerRuiz, this looks really great, there are a number of pretty minor things to fix, and then I'll be happy to merge.
james-d-mitchell
added
the
waiting-for-creator-input
Implemented changes from comments made on PR.
Implemented changes from comments on PR
Clarified the precise use of the LeftGreensMultiplierNC and RightGreensMultiplierNC
Added more appropriate citation.
Gap linted, fixed capitalization, specified the computation is for monoids
Made doc more self consistent. Clarified the definition of the generalized conjugacy class used here. Tagged code and symbols more appropriately.
More tags and consistency changes
Changed argument property
Moved string descriptor for PimMonoidCharacter.
gap lint
quick change to pass tests.
removing group case to see if this passes the last test
putting it back to fail test.
added line to rerun test
Added appropriate citation.
Added cite correctly
To make set render correctly in pdf.
Change implemented.
Capitalization change to match suggested change.
JosephDayngerRuiz
requested review from
reiniscirpons
and removed request for
reiniscirpons and
james-d-mitchell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add several functions which allow for the computation of the character table of a monoid and the Cartan matraix of a monoid which satisfy IsActingSemigroups. The current implementation is close to the original implementation of Balthazar Charles.